Bump TerminalGuiVersion to 2.4.14-develop.28 (needs fixes)#261
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bf397ad06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.2</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.14-develop.28</TerminalGuiVersion> |
There was a problem hiding this comment.
With this default changed to 2.4.14-develop.28, the repository no longer builds as-is: the bump workflow for this exact version failed during dotnet build with obsolete API diagnostics promoted by <TreatWarningsAsErrors>true</TreatWarningsAsErrors> (for example the ConfigurationProperty/SettingsScope usage in src/Terminal.Gui.Editor/Editor.Commands.cs#L24, plus the ted settings usages). Since every normal restore/build now consumes this pin unless overridden, this needs the corresponding source migration or the pin should stay on the previous green version.
Useful? React with 👍 / 👎.
|
Superseded by #264 (merged): develop is now migrated to Terminal.Gui's MEC config path and pinned to stable 2.4.15, which resolves the CS0618 build break these auto-bump PRs hit. Closing and deleting the branch. |
1 participant
Automated bump of
TerminalGuiVersionfrom2.4.14-develop.2to2.4.14-develop.28failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.